feat: unify MapViews styleURL and styleJSON to mapStyle
#559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrauber
approved these changes
Dec 17, 2024
# Conflicts: # src/MLRNModule.ts
|
How do you mein "success" and "failure" tests? I probably should be adding tests for the |
|
Sorry, because of the api change, writing two tests, a success case that shows how to properly use the new prop, and a failure case that ensures that using the old prop fails in the expected way, and hopefully gracefully. I know our test suite is severely lacking ATM though. We can merge this in and address test coverage in another branch at a later date. |
|
Passing one of the old props will simply do nothing. If one uses TypeScript there should be a linting error. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
# [10.0.0-beta.11](v10.0.0-beta.10...v10.0.0-beta.11) (2024-12-17) ### Features * unify `MapView`s `styleURL` and `styleJSON` to `mapStyle` ([#559](#559)) ([7d22f16](7d22f16)) ### BREAKING CHANGES * remove `styleURL` and `styleJSON` from `MapView`, use `mapStyle` instead
|
🎉 This PR is included in version 10.0.0-beta.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512
Migration docs on separate PR.